Noissue - Fix E305 by adapting flake8-abp to use groups, run tests on Python 3.6

flake8-abp/flake8_abp.py

Index: flake8-abp/flake8_abp.py
===================================================================
--- a/flake8-abp/flake8_abp.py
+++ b/flake8-abp/flake8_abp.py
@@ -25,6 +25,7 @@
     import __builtin__ as builtins
 
 import pkg_resources
+import flake8
 
 try:
     ascii
@@ -354,9 +355,6 @@
 
 
 class ASTChecker(object):
-    name = 'abp'
-    version = __version__
-
     def __init__(self, tree, filename):
         self.tree = tree
 
@@ -372,9 +370,6 @@
     if line_number <= 2 and re.search(r'^\s*#.*coding[:=]', physical_line):
         return (0, 'A303 non-default file encoding')
 
-check_non_default_encoding.name = 'abp-non-default-encoding'

[Sebastian Noack, 2017/01/12 15:55:03]

With flake8 3.2.0, it begun to use pycodestyle 2.2.0, introducing an E305 here,
since according to PEP-8 there should be two blank lines below the function
definition. Arguably this doesn't make much sense if the code below assigns
metadata to the same function.

However, it turned out that if we group our checkers together (by using a common
prefix separated by a dot, when registering the entry points in setup.py),
flake8 is using that prefix as name and the __version__ variable of this module,
while the attributes on the individual checkers are obsolete.

Unfortunately, this requires flake8 3, and we are still stuck with flake8 2 for
sitescripts, buildtools and cms where we also use flake8-putty. But we can
basically archive the same for flake8 2, by assigning the same name and version
in a loop, see below.

-check_non_default_encoding.version = __version__
-
 
 def check_quotes(logical_line, tokens, previous_logical, checker_state):
     first_token = True
@@ -427,9 +422,6 @@
 
         first_token = False
 
-check_quotes.name = 'abp-quotes'
-check_quotes.version = __version__
-
 
 def check_redundant_parenthesis(logical_line, tokens):
     start_line = tokens[0][2][0]
@@ -481,5 +473,13 @@
 
     return []
 
-check_redundant_parenthesis.name = 'abp-redundant-parenthesis'
-check_redundant_parenthesis.version = __version__
+
+# With flake8 3, the way the entry points are register in setup.py,
+# they are recognized as a group, and the name and version is detected
+# automatically. For compatibility with flake8 2, however, we need to
+# assign the name and version to each checker individually.
+if int(flake8.__version__.split('.')[0]) < 3:

[Sebastian Noack, 2017/01/12 15:55:03]

We could theoretically skip this check and assign the name and version no matter
what. However, this way it's 1. more obvious that this is a backwards
compatibility hack, 2. we make sure that the new mechanism (i.e. groups) is
already used (and tested) when using flake8 3.

[Vasily Kuznetsov, 2017/01/12 16:08:51]

Acknowledged.

+    for checker in [ASTChecker, check_non_default_encoding,
+                    check_quotes, check_redundant_parenthesis]:
+        checker.name = 'abp'
+        checker.version = __version__