libadblockplus-android-settings/AndroidManifest.xml - Issue 29371750: Issue 4794 - adblock engine creating/releasing concurrency

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-settings/AndroidManifest.xml

Issue 29371750: Issue 4794 - adblock engine creating/releasing concurrency (Closed)

Patch Set: Created Jan. 13, 2017, 11:44 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android-settings/AndroidManifest.xml

diff --git a/libadblockplus-android-settings/AndroidManifest.xml b/libadblockplus-android-settings/AndroidManifest.xml

index b6c713d765f720c028c405fac555fef10d14a29a..a41424dc26ed9e0adbd12cfe522c680399c249c6 100644

--- a/libadblockplus-android-settings/AndroidManifest.xml

+++ b/libadblockplus-android-settings/AndroidManifest.xml

@@ -1,8 +1,8 @@

<?xml version="1.0" encoding="utf-8"?>

<manifest xmlns:android="http://schemas.android.com/apk/res/android"

package="org.adblockplus.libadblockplus.android.settings"

- android:versionCode="1"

- android:versionName="1.0" >

+ android:versionCode="2"

+ android:versionName="1.1" >

diegocarloslima 2017/01/25 11:38:19 I would go for versionName "1.0.1". Since it's a s

anton 2017/01/25 11:51:58 Acknowledged.

<uses-sdk

android:minSdkVersion="21"