Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: chrome/ext/popup.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Patch Set: Workaround limiation with iterating element collections in older versions of Chrome Created Jan. 16, 2017, 8:46 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 (function() 1 "use strict";
2
2 { 3 {
3 var backgroundPage = chrome.extension.getBackgroundPage(); 4 let backgroundPage = chrome.extension.getBackgroundPage();
4 window.ext = Object.create(backgroundPage.ext); 5 window.ext = Object.create(backgroundPage.ext);
5 6
6 ext.closePopup = function() 7 ext.closePopup = () =>
7 { 8 {
8 window.close(); 9 window.close();
9 }; 10 };
10 11
11 // We have to override ext.backgroundPage, because in order 12 // We have to override ext.backgroundPage, because in order
12 // to send messages the local "chrome" namespace must be used. 13 // to send messages the local "chrome" namespace must be used.
13 ext.backgroundPage = { 14 ext.backgroundPage = {
14 sendMessage: chrome.runtime.sendMessage, 15 sendMessage: chrome.runtime.sendMessage,
15 16
16 getWindow: function() 17 getWindow() { return backgroundPage; }
17 {
18 return backgroundPage;
19 }
20 }; 18 };
21 })(); 19 }
OLDNEW
« no previous file with comments | « chrome/ext/devtools.js ('k') | composer.js » ('j') | lib/notificationHelper.js » ('J')

Powered by Google App Engine
This is Rietveld