Issue 4795 - Use modern JavaScript syntax

chrome/ext/content.js

-chrome.runtime.onMessage.addListener(function(message, sender, sendResponse)
+"use strict";
+
+chrome.runtime.onMessage.addListener((message, sender, sendResponse) =>
 {
   return ext.onMessage._dispatch(message, {}, sendResponse).indexOf(true) != -1;
 });
 
-ext.onExtensionUnloaded = (function()
+ext.onExtensionUnloaded = (() =>

[Sebastian Noack, 2017/01/16 15:35:55]

The IFEE here existed originally to encapsulate the underlying port without
exporting it. As for the other IFEEs, the same can be achieved without, thanks
to block-scoping:

  {
    let port = null;

    ext.onExtensionUnloaded = {
      ...
    };
  }

[kzar, 2017/01/17 07:42:44]

Done.

 {
-  var port = null;
+  let port = null;
 
   return {
-    addListener: function(listener)
+    addListener(listener)
     {
       if (!port)
         port = chrome.runtime.connect();
 
       // When the extension is reloaded, disabled or uninstalled the
       // background page dies and automatically disconnects all ports
       port.onDisconnect.addListener(listener);
     },
-    removeListener: function(listener)
+    removeListener(listener)
     {
       if (port)
       {
         port.onDisconnect.removeListener(listener);
 
         if (!port.onDisconnect.hasListeners())
         {
           port.disconnect();
           port = null;
         }
       }
     }
   };
 })();