Issue 4795 - Use modern JavaScript syntax

chrome/ext/popup.js

-(function()
+"use strict";
+
 {
-  var backgroundPage = chrome.extension.getBackgroundPage();
+  const backgroundPage = chrome.extension.getBackgroundPage();
   window.ext = Object.create(backgroundPage.ext);

[Sebastian Noack, 2017/01/18 11:24:26]

Assigning to the global object (i.e. window) isn't necessary anymore. Using var
seems more appropriate here. However, this wasn't possible before because this
code was wrapped by an IFEE. Feel free to grab for window through the repository
to find more cases like that.

[kzar, 2017/01/18 11:46:36]

Done.

 
-  ext.closePopup = function()
+  ext.closePopup = () =>
   {
     window.close();
   };
 
   // We have to override ext.backgroundPage, because in order
   // to send messages the local "chrome" namespace must be used.
   ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
 
-    getWindow: function()
+    getWindow()
     {
       return backgroundPage;
     }
   };
-})();
+}