Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ext/background.js ('k') | include.preload.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict";
18 19
19 (function()
20 { 20 {
21 window.ext = {}; 21 var ext = {};
22 22
23 var EventTarget = ext._EventTarget = function() 23 let EventTarget = ext._EventTarget = function()
24 { 24 {
25 this._listeners = []; 25 this._listeners = [];
26 }; 26 };
27 EventTarget.prototype = { 27 EventTarget.prototype = {
28 addListener: function(listener) 28 addListener(listener)
29 { 29 {
30 if (this._listeners.indexOf(listener) == -1) 30 if (this._listeners.indexOf(listener) == -1)
31 this._listeners.push(listener); 31 this._listeners.push(listener);
32 }, 32 },
33 removeListener: function(listener) 33 removeListener(listener)
34 { 34 {
35 var idx = this._listeners.indexOf(listener); 35 let idx = this._listeners.indexOf(listener);
36 if (idx != -1) 36 if (idx != -1)
37 this._listeners.splice(idx, 1); 37 this._listeners.splice(idx, 1);
38 }, 38 },
39 _dispatch: function() 39 _dispatch()
40 { 40 {
41 var results = []; 41 let results = [];
42 var listeners = this._listeners.slice(); 42 let listeners = this._listeners.slice();
43 43
44 for (var i = 0; i < listeners.length; i++) 44 for (let listener of listeners)
45 results.push(listeners[i].apply(null, arguments)); 45 results.push(listener.apply(null, arguments));
46 46
47 return results; 47 return results;
48 } 48 }
49 }; 49 };
50 })(); 50 }
OLDNEW
« no previous file with comments | « ext/background.js ('k') | include.preload.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld