Issue 4795 - Use modern JavaScript syntax

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+"use strict";
 
-(function()
 {
-  window.ext = {};
+  var ext = {};
 
-  var EventTarget = ext._EventTarget = function()
+  let EventTarget = ext._EventTarget = function()
   {
     this._listeners = [];
   };
   EventTarget.prototype = {
-    addListener: function(listener)
+    addListener(listener)
     {
       if (this._listeners.indexOf(listener) == -1)
         this._listeners.push(listener);
     },
-    removeListener: function(listener)
+    removeListener(listener)
     {
-      var idx = this._listeners.indexOf(listener);
+      let idx = this._listeners.indexOf(listener);
       if (idx != -1)
         this._listeners.splice(idx, 1);
     },
-    _dispatch: function()
+    _dispatch()
     {
-      var results = [];
-      var listeners = this._listeners.slice();
+      let results = [];
+      let listeners = this._listeners.slice();
 
-      for (var i = 0; i < listeners.length; i++)
-        results.push(listeners[i].apply(null, arguments));
+      for (let listener of listeners)
+        results.push(listener.apply(null, arguments));
 
       return results;
     }
   };
-})();
+}