Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/ext/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Left Patch Set: Created Jan. 13, 2017, 12:11 p.m.
Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « chrome/ext/background.js ('k') | chrome/ext/content.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict";
19
18 { 20 {
21 // Workaround since HTMLCollection and NodeList didn't have iterator support
22 // before Chrome 51.
23 // https://bugs.chromium.org/p/chromium/issues/detail?id=401699
24 if (!(Symbol.iterator in HTMLCollection.prototype))
25 HTMLCollection.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator] ;
26 if (!(Symbol.iterator in NodeList.prototype))
27 NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator];
28
19 /* Message passing */ 29 /* Message passing */
20 30
21 ext.onMessage = new ext._EventTarget(); 31 ext.onMessage = new ext._EventTarget();
22 32
23 33
24 /* Background page */ 34 /* Background page */
25 35
26 ext.backgroundPage = { 36 ext.backgroundPage = {
27 sendMessage: chrome.runtime.sendMessage, 37 sendMessage: chrome.runtime.sendMessage,
28 getWindow: () => chrome.extension.getBackgroundPage() 38 getWindow()
Sebastian Noack 2017/01/13 12:30:50 I think for method definitions, the method definit
kzar 2017/01/16 04:09:11 According to this page[1] they are. Also I just te
39 {
40 return chrome.extension.getBackgroundPage();
41 }
29 }; 42 };
30 43
31 44
32 /* Utils */ 45 /* Utils */
33 46
34 ext.getURL = chrome.extension.getURL; 47 ext.getURL = chrome.extension.getURL;
35 ext.i18n = chrome.i18n; 48 ext.i18n = chrome.i18n;
36 } 49 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld