Issue 4795 - Use modern JavaScript syntax

lib/uninstall.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /** @module uninstall */
 
 "use strict";
 
-let info = require("info");
-let {Prefs} = require("prefs");
-let {Utils} = require("utils");
+const info = require("info");
+const {Prefs} = require("prefs");
+const {Utils} = require("utils");
 
 function setUninstallURL()
 {
   let search = [];
-  let keys = ["addonName", "addonVersion", "application", "applicationVersion",
-              "platform", "platformVersion"];
-  for (let key of keys)
+  for (let key of ["addonName", "addonVersion", "application",
+                   "applicationVersion", "platform", "platformVersion"])
     search.push(key + "=" + encodeURIComponent(info[key]));
 
   let downlCount = Prefs.notificationdata.downloadCount || 0;
 
   if (downlCount > 4)
   {
     if (downlCount < 8)
       downlCount = "5-7";
     else if (downlCount < 30)
       downlCount = "8-29";
@@ skipping 12 matching lines @@
 }
 
 // The uninstall URL contains the notification download count as a parameter,
 // therefore we must wait for preferences to be loaded before generating the
 // URL and we need to re-generate it each time the notification data changes.
 if ("setUninstallURL" in chrome.runtime)
 {
   Prefs.untilLoaded.then(setUninstallURL);
   Prefs.on("notificationdata", setUninstallURL);
 }