chrome/ext/common.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: chrome/ext/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Left Patch Set: Workaround limiation with iterating element collections in older versions of Chrome Created Jan. 16, 2017, 8:46 a.m.

Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2016 Eyeo GmbH	3 * Copyright (C) 2006-2016 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 17 matching lines...) Expand all Loading...
28	28

29 /* Message passing */	29 /* Message passing */

30	30

31 ext.onMessage = new ext._EventTarget();	31 ext.onMessage = new ext._EventTarget();

32	32

33	33

34 /* Background page */	34 /* Background page */

35	35

36 ext.backgroundPage = {	36 ext.backgroundPage = {

37 sendMessage: chrome.runtime.sendMessage,	37 sendMessage: chrome.runtime.sendMessage,

38 getWindow() { return chrome.extension.getBackgroundPage(); }	38 getWindow()

	39 {

	40 return chrome.extension.getBackgroundPage();

	41 }

39 };	42 };

40	43

41	44

42 /* Utils */	45 /* Utils */

43	46

44 ext.getURL = chrome.extension.getURL;	47 ext.getURL = chrome.extension.getURL;

45 ext.i18n = chrome.i18n;	48 ext.i18n = chrome.i18n;

46 }	49 }

LEFT	RIGHT