Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/ext/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Left Patch Set: Fix scoping regression Created Jan. 16, 2017, 9:12 a.m.
Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « chrome/ext/background.js ('k') | chrome/ext/content.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 17 matching lines...) Expand all
28 28
29 /* Message passing */ 29 /* Message passing */
30 30
31 ext.onMessage = new ext._EventTarget(); 31 ext.onMessage = new ext._EventTarget();
32 32
33 33
34 /* Background page */ 34 /* Background page */
35 35
36 ext.backgroundPage = { 36 ext.backgroundPage = {
37 sendMessage: chrome.runtime.sendMessage, 37 sendMessage: chrome.runtime.sendMessage,
38 getWindow() { return chrome.extension.getBackgroundPage(); } 38 getWindow()
Sebastian Noack 2017/01/16 14:47:40 Turning this into a one-liner seems unrelated. I'm
kzar 2017/01/16 14:59:07 Done.
39 {
40 return chrome.extension.getBackgroundPage();
41 }
39 }; 42 };
40 43
41 44
42 /* Utils */ 45 /* Utils */
43 46
44 ext.getURL = chrome.extension.getURL; 47 ext.getURL = chrome.extension.getURL;
45 ext.i18n = chrome.i18n; 48 ext.i18n = chrome.i18n;
46 } 49 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld