Issue 4795 - Use modern JavaScript syntax

chrome/ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
 
   /* Message passing */
 
   ext.onMessage = new ext._EventTarget();
 
 
   /* Background page */
 
   ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
-    getWindow() { return chrome.extension.getBackgroundPage(); }

[Sebastian Noack, 2017/01/16 14:47:40]

Turning this into a one-liner seems unrelated. I'm also undecided whether
compressing a function (except for arrow functions) into a single line makes the
the code harder to read. As for consistency, I think we generally avoid that.

[kzar, 2017/01/16 14:59:07]

Done.

+    getWindow()
+    {
+      return chrome.extension.getBackgroundPage();
+    }
   };
 
 
   /* Utils */
 
   ext.getURL = chrome.extension.getURL;
   ext.i18n = chrome.i18n;
 }