Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: utils.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Left Patch Set: Addressed feedback, used destructuring Created Jan. 17, 2017, 7:39 a.m.
Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « subscriptionLink.postload.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 "use strict"; 1 "use strict";
2 2
3 let backgroundPage = ext.backgroundPage.getWindow(); 3 const {require, Services} = ext.backgroundPage.getWindow();
4 let require = backgroundPage.require;
5 4
6 let Services = backgroundPage.Services; 5 const {Synchronizer} = require("synchronizer");
7 let {Synchronizer} = require("synchronizer"); 6 const {Utils} = require("utils");
8 let {Utils} = require("utils"); 7 const {Prefs} = require("prefs");
9 let {Prefs} = require("prefs"); 8 const {FilterStorage} = require("filterStorage");
10 let {FilterStorage} = require("filterStorage"); 9 const {FilterNotifier} = require("filterNotifier");
11 let {FilterNotifier} = require("filterNotifier");
12 10
13 let {Subscription, DownloadableSubscription} = require("subscriptionClasses"); 11 const {Subscription, DownloadableSubscription} = require("subscriptionClasses");
14 let {Filter, BlockingFilter} = require("filterClasses"); 12 const {Filter, BlockingFilter} = require("filterClasses");
15 let {defaultMatcher} = require("matcher"); 13 const {defaultMatcher} = require("matcher");
16 14
17 /** 15 /**
18 * Shortcut for document.getElementById(id) 16 * Shortcut for document.getElementById(id)
19 */ 17 */
20 function E(id) 18 function E(id)
21 { 19 {
22 return document.getElementById(id); 20 return document.getElementById(id);
23 } 21 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld