utils.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: utils.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Left Patch Set: Define and destructure backgroundPage more consistently, fix minor whitespace errors Created Jan. 18, 2017, 7:34 a.m.

Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 "use strict";	1 "use strict";

2	2

3 const backgroundPage = ext.backgroundPage.getWindow();	3 const {require, Services} = ext.backgroundPage.getWindow();

4 const {require, Services} = backgroundPage;
Sebastian Noack 2017/01/18 11:24:30 Note that backgroundPage isn't used anywhere else, Note that backgroundPage isn't used anywhere else, so how about this: const {require, Services} = ext.backgroundPage.getWindow(); kzar 2017/01/18 11:46:41 Done. Show quoted text On 2017/01/18 11:24:30, Sebastian Noack wrote: > Note that backgroundPage isn't used anywhere else, so how about this: > > const {require, Services} = ext.backgroundPage.getWindow(); Done.
5	4

6 const {Synchronizer} = require("synchronizer");	5 const {Synchronizer} = require("synchronizer");

7 const {Utils} = require("utils");	6 const {Utils} = require("utils");

8 const {Prefs} = require("prefs");	7 const {Prefs} = require("prefs");

9 const {FilterStorage} = require("filterStorage");	8 const {FilterStorage} = require("filterStorage");

10 const {FilterNotifier} = require("filterNotifier");	9 const {FilterNotifier} = require("filterNotifier");

11	10

12 const {Subscription, DownloadableSubscription} = require("subscriptionClasses");	11 const {Subscription, DownloadableSubscription} = require("subscriptionClasses");

13 const {Filter, BlockingFilter} = require("filterClasses");	12 const {Filter, BlockingFilter} = require("filterClasses");

14 const {defaultMatcher} = require("matcher");	13 const {defaultMatcher} = require("matcher");

15	14

16 /**	15 /**

17 * Shortcut for document.getElementById(id)	16 * Shortcut for document.getElementById(id)

18 */	17 */

19 function E(id)	18 function E(id)

20 {	19 {

21 return document.getElementById(id);	20 return document.getElementById(id);

22 }	21 }

LEFT	RIGHT