Issue 4795 - Use modern JavaScript syntax

chrome/ext/common.js

Index: chrome/ext/common.js
diff --git a/chrome/ext/common.js b/chrome/ext/common.js
index 2e5c776dccb493894383117b12bebafc411587b5..e6efce2f466f776f42496d610a8f8034dbf9b2ba 100644
--- a/chrome/ext/common.js
+++ b/chrome/ext/common.js
@@ -15,7 +15,6 @@
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-(function()

[Sebastian Noack, 2017/01/13 12:30:50]

As mentioned on the other review, unless you use strict mode, named functions
are still defined globally without IFEE. There are no named functions in this
file, but while on it, why not just add "use strict" everywhere as well? This is
arguably any more risky than the changes you are doing here anyway. And that way
we don't potentially export any named functions (in the future), plus we benefit
from other advantages of strict mode.

[kzar, 2017/01/16 04:09:11]

Done.

 {
   /* Message passing */
 
@@ -26,10 +25,7 @@
 
   ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
-    getWindow: function()
-    {
-      return chrome.extension.getBackgroundPage();
-    }
+    getWindow: () => chrome.extension.getBackgroundPage()

[Sebastian Noack, 2017/01/13 12:30:50]

I think for method definitions, the method definition shorthand syntax is
preferable over arrow functions:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/M...

The only question is whether it is supported by Microsoft Edge, yet?

[kzar, 2017/01/16 04:09:11]

According to this page[1] they are. Also I just tested them in Edge 38 myself
and they seem to work OK. Done.

[1] - http://kangax.github.io/compat-table/es5/

   };
 
 
@@ -37,4 +33,4 @@
 
   ext.getURL = chrome.extension.getURL;
   ext.i18n = chrome.i18n;
-})();
+}