Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Patch Set: Created Jan. 13, 2017, 12:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ext/common.js
diff --git a/ext/common.js b/ext/common.js
index c75ced186d633fc3bf4183be4fb5d9dd6c5db666..ea93e710ec1d87289ad54c51a11c5096682e1b2c 100644
--- a/ext/common.js
+++ b/ext/common.js
@@ -16,11 +16,10 @@
*/
-(function()
{
window.ext = {};
- var EventTarget = ext._EventTarget = function()
+ let EventTarget = ext._EventTarget = function()
{
this._listeners = [];
};
@@ -32,19 +31,19 @@
},
removeListener: function(listener)
{
- var idx = this._listeners.indexOf(listener);
+ let idx = this._listeners.indexOf(listener);
if (idx != -1)
this._listeners.splice(idx, 1);
},
_dispatch: function()
{
- var results = [];
- var listeners = this._listeners.slice();
+ let results = [];
+ let listeners = this._listeners.slice();
- for (var i = 0; i < listeners.length; i++)
- results.push(listeners[i].apply(null, arguments));
+ for (let listener of listeners)
+ results.push(listener.apply(null, arguments));
return results;
}
};
-})();
+}
« chrome/ext/common.js ('K') | « ext/background.js ('k') | include.preload.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld