Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Patch Set: Workaround limiation with iterating element collections in older versions of Chrome Created Jan. 16, 2017, 8:46 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ext/common.js
diff --git a/ext/common.js b/ext/common.js
index c75ced186d633fc3bf4183be4fb5d9dd6c5db666..9a791fa94f51ecb61e876e77b6b2b6600dc811c5 100644
--- a/ext/common.js
+++ b/ext/common.js
@@ -15,36 +15,36 @@
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
+"use strict";
-(function()
{
window.ext = {};
- var EventTarget = ext._EventTarget = function()
+ let EventTarget = ext._EventTarget = function()
{
this._listeners = [];
};
EventTarget.prototype = {
- addListener: function(listener)
+ addListener(listener)
{
if (this._listeners.indexOf(listener) == -1)
this._listeners.push(listener);
},
- removeListener: function(listener)
+ removeListener(listener)
{
- var idx = this._listeners.indexOf(listener);
+ let idx = this._listeners.indexOf(listener);
if (idx != -1)
this._listeners.splice(idx, 1);
},
- _dispatch: function()
+ _dispatch()
{
- var results = [];
- var listeners = this._listeners.slice();
+ let results = [];
+ let listeners = this._listeners.slice();
- for (var i = 0; i < listeners.length; i++)
- results.push(listeners[i].apply(null, arguments));
+ for (let listener of listeners)
+ results.push(listener.apply(null, arguments));
return results;
}
};
-})();
+}
« no previous file with comments | « ext/background.js ('k') | include.preload.js » ('j') | lib/notificationHelper.js » ('J')

Powered by Google App Engine
This is Rietveld