qunit/common.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: qunit/common.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Patch Set: Fix scoping regression Created Jan. 16, 2017, 9:12 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: qunit/common.js

diff --git a/qunit/common.js b/qunit/common.js

index 8142b621d4e71d019239b964b1d52bb4fb6943d8..906348ce243b91729a5067c9dcfe1c47627fc0b4 100644

--- a/qunit/common.js

+++ b/qunit/common.js

@@ -15,6 +15,7 @@

* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

+"use strict";

importAll("filterClasses", this);

importAll("subscriptionClasses", this);

@@ -43,9 +44,9 @@ function restoreFilterComponents()

function preparePrefs()

{

this._pbackup = Object.create(null);

- for (var pref in Prefs)

+ for (let pref in Prefs)

{

- var value = Prefs[pref];

+ let value = Prefs[pref];

this._pbackup[pref] = value;

}

Prefs.enabled = true;

@@ -53,7 +54,7 @@ function preparePrefs()

function restorePrefs()

{

- for (var pref in this._pbackup)

+ for (let pref in this._pbackup)

Prefs[pref] = this._pbackup[pref];

}