chrome/ext/popup.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/ext/popup.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Patch Set: Define and destructure backgroundPage more consistently, fix minor whitespace errors Created Jan. 18, 2017, 7:34 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/ext/popup.js

diff --git a/chrome/ext/popup.js b/chrome/ext/popup.js

index 40932374211505989553c15352d2e7215e7d07da..c6f7787daa54a027415bf4d6d395ffa8afeb4556 100644

--- a/chrome/ext/popup.js

+++ b/chrome/ext/popup.js

@@ -1,9 +1,10 @@

-(function()

+"use strict";

{

- var backgroundPage = chrome.extension.getBackgroundPage();

+ const backgroundPage = chrome.extension.getBackgroundPage();

window.ext = Object.create(backgroundPage.ext);

Sebastian Noack 2017/01/18 11:24:26 Assigning to the global object (i.e. window) isn't

kzar 2017/01/18 11:46:36 Done.

- ext.closePopup = function()

+ ext.closePopup = () =>

{

window.close();

};

@@ -13,9 +14,9 @@

ext.backgroundPage = {

sendMessage: chrome.runtime.sendMessage,

- getWindow: function()

+ getWindow()

{

return backgroundPage;

}

};

-})();