lib/icon.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/icon.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/icon.js

diff --git a/lib/icon.js b/lib/icon.js

index a2e56a174a24d4c36fec0a658c108990bc92e8bb..c7590fce9c8f4bef26cbb7ab428a58b7ee97afed 100644

--- a/lib/icon.js

+++ b/lib/icon.js

@@ -19,7 +19,7 @@

"use strict";

-let {FilterNotifier} = require("filterNotifier");

+const {FilterNotifier} = require("filterNotifier");

const frameOpacities = [0.0, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9,

1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0,

@@ -185,7 +185,7 @@ let stopIconAnimation =

* @return {Promise} A promise that is fullfilled when

* the icon animation has been stopped.

-exports.stopIconAnimation = function()

+exports.stopIconAnimation = () =>

{

stopRequested = true;

return notRunning.then(() =>

@@ -201,7 +201,7 @@ exports.stopIconAnimation = function()

* @param {string} type The notification type (i.e: "information" or "critical")

-exports.startIconAnimation = function(type)

+exports.startIconAnimation = type =>

{

notRunning = new Promise(resolve =>

{

« no previous file with comments | « lib/filterValidation.js ('k') | lib/io.js » ('j') | no next file with comments »