Noissue - [hgreview] Only use first line of commit message as review title

hgreview.py

 import BaseHTTPServer
 import os
 import re
 import socket
 import sys
 import urllib
 
 from mercurial import cmdutil, error
 
 SERVER = 'https://codereview.adblockplus.org'
@@ skipping 40 matching lines @@
     if opts.get('change'):
         rev = repo[opts['change']]
         args.extend(['--rev', '{}:{}'.format(rev.parents()[0], rev)])
     elif opts.get('revision'):
         args.extend(['--rev', opts['revision']])
     else:
         raise error.Abort('What should be reviewed? Either --revision or --change is required.')
 
     if not opts.get('issue'):
         # New issue, make sure title and message are set
-        if not opts.get('title') and opts.get('change'):
-            opts['title'] = repo[opts['change']].description().rstrip().split('\n')[0]

[Vasily Kuznetsov, 2017/01/13 17:58:08]

There's a bit too much code repetition here and, more dangerously, we're
overwriting opts['message'] even though the user might have supplied it.

It seems better to do something like this:

    if opts.get('change'):
        description = repo[opts['change']].description()
    else:
        # Code from line 65, maybe the prompt can be changed...
        description = ui.prompt('New review title: ', '')

    # Here we'd have the check from line 66 applied to description instead.

Then we can use `description` for providing default values for opts['title'] in
line 62 and opts['message'] in line 69.

[f.nicolaisen, 2017/01/15 22:48:09]

Acknowledged.

-            opts['message'] = repo[opts['change']].description()
-        if not opts.get('title'):
+        fulltitle = None
+
+        if not opts.get('title') and not opts.get('change'):
             opts['title'] = ui.prompt('New review title: ', '')
+        elif not opts.get('title'):
+            fulltitle = repo[opts['change']].description()
+            opts['title'] = fulltitle.rstrip().split('\n')[0]
+
         if not opts['title'].strip():
             raise error.Abort('No review title given.')
 
         if not opts.get('message'):
-            opts['message'] = opts['title']
+            opts['message'] = fulltitle or opts['title']
 
         path = (ui.config('paths', 'default-push')
                 or ui.config('paths', 'default')
                 or '')
         match = re.search(r'^(?:https://|ssh://hg@)(.*)', path)
         if match:
             opts['base_url'] = 'https://' + match.group(1)
 
         # Make sure there is at least one reviewer
         if not opts.get('reviewers'):
@@ skipping 76 matching lines @@
   </body>
 </html>
 ''' % port
 
     # Run the upload tool
     issue, patchset = scope['RealMain']([upload_path] + args)
 
     # Wait for the page to check in and retrieve issue URL
     if server:
         server.handle_request()