Noissue - [hgreview] Only use first line of commit message as review title

hgreview.py

Index: hgreview.py
===================================================================
--- a/hgreview.py
+++ b/hgreview.py
@@ -59,7 +59,8 @@
     if not opts.get('issue'):
         # New issue, make sure title and message are set
         if not opts.get('title') and opts.get('change'):
-            opts['title'] = repo[opts['change']].description()
+            opts['title'] = repo[opts['change']].description().rstrip().split('\n')[0]

[Vasily Kuznetsov, 2017/01/13 17:58:08]

There's a bit too much code repetition here and, more dangerously, we're
overwriting opts['message'] even though the user might have supplied it.

It seems better to do something like this:

    if opts.get('change'):
        description = repo[opts['change']].description()
    else:
        # Code from line 65, maybe the prompt can be changed...
        description = ui.prompt('New review title: ', '')

    # Here we'd have the check from line 66 applied to description instead.

Then we can use `description` for providing default values for opts['title'] in
line 62 and opts['message'] in line 69.

[f.nicolaisen, 2017/01/15 22:48:09]

Acknowledged.

+            opts['message'] = repo[opts['change']].description()
         if not opts.get('title'):
             opts['title'] = ui.prompt('New review title: ', '')
         if not opts['title'].strip():