Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: hgreview.py

Issue 29371804: Noissue - [hgreview] Only use first line of commit message as review title (Closed) Base URL: https://hg.adblockplus.org/codingtools/
Patch Set: Trying again Created July 18, 2017, 11:45 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: hgreview.py
===================================================================
--- a/hgreview.py
+++ b/hgreview.py
@@ -58,15 +58,19 @@
if not opts.get('issue'):
# New issue, make sure title and message are set
- if not opts.get('title') and opts.get('change'):
- opts['title'] = repo[opts['change']].description()
- if not opts.get('title'):
+ fulltitle = None
+
+ if not opts.get('title') and not opts.get('change'):
opts['title'] = ui.prompt('New review title: ', '')
+ elif not opts.get('title') and opts.get('change'):
Wladimir Palant 2017/07/18 12:06:02 Nit: `and opts.get('change')` is unnecessary here.
f.nicolaisen 2017/07/18 12:17:57 How? It could be that the submitter wants the prom
Wladimir Palant 2017/07/18 12:27:18 No, we would get into the prompt case then. And si
f.nicolaisen 2017/07/18 13:46:39 Acknowledged.
+ fulltitle = repo[opts['change']].description()
+ opts['title'] = fulltitle.rstrip().split('\n')[0]
+
if not opts['title'].strip():
raise error.Abort('No review title given.')
if not opts.get('message'):
- opts['message'] = opts['title']
+ opts['message'] = fulltitle or opts['title']
path = (ui.config('paths', 'default-push')
or ui.config('paths', 'default')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld