Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: options.js

Issue 29371945: Issue 4802 - Add back compatibility for Microsoft Edge after #4722 removed it (Closed)
Left Patch Set: Created Jan. 16, 2017, 6:33 a.m.
Right Patch Set: Specify the version of Edge where the issue is observed Created Jan. 18, 2017, 3:57 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « options.html ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 if (arguments.length > 0) 49 if (arguments.length > 0)
50 { 50 {
51 var lastArg = arguments[arguments.length - 1]; 51 var lastArg = arguments[arguments.length - 1];
52 if (typeof lastArg == "function") 52 if (typeof lastArg == "function")
53 callback = lastArg; 53 callback = lastArg;
54 54
55 for (var i = 0; i < arguments.length - (callback ? 1 : 0); i++) 55 for (var i = 0; i < arguments.length - (callback ? 1 : 0); i++)
56 message[paramKeys[i]] = arguments[i]; 56 message[paramKeys[i]] = arguments[i];
57 } 57 }
58 58
59 // Edge silently fails when sendMessage is called with a callback 59 // Edge 38.14393 silently fails when sendMessage is called with a callback
60 // parameter of undefined, so we work around that here. 60 // parameter of null, so we work around that here.
kzar 2017/01/18 04:49:50 The callback parameter will be `undefined` not `nu
Oleksandr 2017/01/19 20:51:01 The issue on Microsoft's issue tracker just mentio
61 // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8504 730/
61 if (callback) 62 if (callback)
62 ext.backgroundPage.sendMessage(message, callback); 63 ext.backgroundPage.sendMessage(message, callback);
63 else 64 else
64 ext.backgroundPage.sendMessage(message); 65 ext.backgroundPage.sendMessage(message);
65 }; 66 };
66 } 67 }
67 68
68 var getDocLink = wrapper({type: "app.get", what: "doclink"}, "link"); 69 var getDocLink = wrapper({type: "app.get", what: "doclink"}, "link");
69 var getInfo = wrapper({type: "app.get"}, "what"); 70 var getInfo = wrapper({type: "app.get"}, "what");
70 var getPref = wrapper({type: "prefs.get"}, "key"); 71 var getPref = wrapper({type: "prefs.get"}, "key");
(...skipping 661 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 onFilterMessage(message.action, message.args[0]); 733 onFilterMessage(message.action, message.args[0]);
733 break; 734 break;
734 case "prefs.respond": 735 case "prefs.respond":
735 onPrefMessage(message.action, message.args[0]); 736 onPrefMessage(message.action, message.args[0]);
736 break; 737 break;
737 case "subscriptions.respond": 738 case "subscriptions.respond":
738 onSubscriptionMessage(message.action, message.args[0]); 739 onSubscriptionMessage(message.action, message.args[0]);
739 break; 740 break;
740 } 741 }
741 }); 742 });
LEFTRIGHT
« options.html ('k') | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld