Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: options.js

Issue 29371945: Issue 4802 - Add back compatibility for Microsoft Edge after #4722 removed it (Closed)
Patch Set: Don't touch the buildtools dependency Created Jan. 17, 2017, 5:46 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « options.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: options.js
===================================================================
--- a/options.js
+++ b/options.js
@@ -56,7 +56,12 @@
message[paramKeys[i]] = arguments[i];
}
- ext.backgroundPage.sendMessage(message, callback);
+ // Edge silently fails when sendMessage is called with a callback
kzar 2017/01/17 06:54:31 Did you file an issue for this with Microsoft? (Or
Oleksandr 2017/01/18 03:08:44 The issue is marked as Fixed, however it is not cl
kzar 2017/01/18 03:48:41 OK well add a link to that issue here and also upd
+ // parameter of undefined, so we work around that here.
+ if (callback)
+ ext.backgroundPage.sendMessage(message, callback);
+ else
+ ext.backgroundPage.sendMessage(message);
};
}
« no previous file with comments | « options.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld