Unified Diff: options.js
Issue 29371945:
Issue 4802 - Add back compatibility for Microsoft Edge after #4722 removed it (Closed)
Patch Set: Specify the version of Edge where the issue is observed
Created Jan. 18, 2017, 3:57 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« options.html ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.js |
| =================================================================== |
| --- a/options.js |
| +++ b/options.js |
| @@ -56,7 +56,13 @@ |
| message[paramKeys[i]] = arguments[i]; |
| } |
| - ext.backgroundPage.sendMessage(message, callback); |
| + // Edge 38.14393 silently fails when sendMessage is called with a callback |
| + // parameter of null, so we work around that here. |
|
kzar
2017/01/18 04:49:50
The callback parameter will be `undefined` not `nu
Oleksandr
2017/01/19 20:51:01
The issue on Microsoft's issue tracker just mentio
|
| + // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8504730/ |
| + if (callback) |
| + ext.backgroundPage.sendMessage(message, callback); |
| + else |
| + ext.backgroundPage.sendMessage(message); |
| }; |
| } |
« no previous file with comments
|
« options.html ('k')
|
no next file »
|
no next file with comments »
