Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29371951: Noissue - Add some more JavaScript coding guidlines (Closed)

Created:
Jan. 16, 2017, 7:04 a.m. by kzar
Modified:
Jan. 19, 2017, 3:59 a.m.
Visibility:
Public.

Description

Noissue - Add some more JavaScript coding guidlines

Patch Set 1 #

Total comments: 23

Patch Set 2 : Addressed feedback #

Total comments: 17

Patch Set 3 : Addressed feedback, reordered rules added const rule #

Total comments: 10

Patch Set 4 : Addressed feedback #

Total comments: 4

Patch Set 5 : Addressed further feedback #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M pages/coding-style.html View 1 2 3 4 1 chunk +12 lines, -2 lines 3 comments Download

Messages

Total messages: 14
kzar
Patch Set 1 As discussed in the other review[1]. While at it I've added some ...
Jan. 16, 2017, 7:08 a.m. (2017-01-16 07:08:23 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29371951/diff/29371952/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29371952/pages/coding-style.html#newcode28 pages/coding-style.html:28: <li>{{javascript-this Use <code>bind()</code> (or arrow functions) to ensure the ...
Jan. 16, 2017, 5:07 p.m. (2017-01-16 17:07:14 UTC) #2
kzar
Patch Set 2 : Addressed feedback https://codereview.adblockplus.org/29371951/diff/29371952/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29371952/pages/coding-style.html#newcode28 pages/coding-style.html:28: <li>{{javascript-this Use <code>bind()</code> ...
Jan. 17, 2017, 6:48 a.m. (2017-01-17 06:48:52 UTC) #3
saroyanm
https://codereview.adblockplus.org/29371951/diff/29372129/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372129/pages/coding-style.html#newcode31 pages/coding-style.html:31: <li>{{javascript-this When required (and when arrow functions cannot be ...
Jan. 17, 2017, 12:26 p.m. (2017-01-17 12:26:05 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29371951/diff/29372129/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372129/pages/coding-style.html#newcode29 pages/coding-style.html:29: <li>{{javascript-block-scoping If supported, use <a href="https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/block">block-scoping</a> (<code><fix>let</fix></code>), except when ...
Jan. 17, 2017, 10:31 p.m. (2017-01-17 22:31:39 UTC) #5
kzar
Patch Set 3 : Addressed feedback, reordered rules added const rule https://codereview.adblockplus.org/29371951/diff/29372129/pages/coding-style.html File pages/coding-style.html (right): ...
Jan. 18, 2017, 6:33 a.m. (2017-01-18 06:33:52 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29371951/diff/29372265/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372265/pages/coding-style.html#newcode30 pages/coding-style.html:30: <li>{{javascript-if-else-braces When an <code><fix>if</fix></code> statement, an <code><fix>else</fix></code> statement or ...
Jan. 18, 2017, 9:56 a.m. (2017-01-18 09:56:20 UTC) #7
kzar
Patch Set 4 : Addressed feedback https://codereview.adblockplus.org/29371951/diff/29372265/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372265/pages/coding-style.html#newcode30 pages/coding-style.html:30: <li>{{javascript-if-else-braces When an ...
Jan. 18, 2017, 10:26 a.m. (2017-01-18 10:26:43 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29371951/diff/29372555/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372555/pages/coding-style.html#newcode29 pages/coding-style.html:29: <li>{{javascript-opening-braces Opening braces of object literals don't go on ...
Jan. 18, 2017, 10:54 a.m. (2017-01-18 10:54:32 UTC) #9
kzar
Patch Set 5 : Addressed further feedback https://codereview.adblockplus.org/29371951/diff/29372555/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372555/pages/coding-style.html#newcode29 pages/coding-style.html:29: <li>{{javascript-opening-braces Opening ...
Jan. 18, 2017, 11:10 a.m. (2017-01-18 11:10:09 UTC) #10
saroyanm
LGTM https://codereview.adblockplus.org/29371951/diff/29372557/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372557/pages/coding-style.html#newcode37 pages/coding-style.html:37: <li>{{javascript-for-of When iterating over arrays in the canonical ...
Jan. 18, 2017, 11:27 a.m. (2017-01-18 11:27:03 UTC) #11
Sebastian Noack
https://codereview.adblockplus.org/29371951/diff/29372557/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372557/pages/coding-style.html#newcode37 pages/coding-style.html:37: <li>{{javascript-for-of When iterating over arrays in the canonical order ...
Jan. 18, 2017, 11:38 a.m. (2017-01-18 11:38:09 UTC) #12
saroyanm
https://codereview.adblockplus.org/29371951/diff/29372557/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29371951/diff/29372557/pages/coding-style.html#newcode37 pages/coding-style.html:37: <li>{{javascript-for-of When iterating over arrays in the canonical order ...
Jan. 18, 2017, 11:49 a.m. (2017-01-18 11:49:49 UTC) #13
Sebastian Noack
Jan. 18, 2017, 12:04 p.m. (2017-01-18 12:04:30 UTC) #14
FWIW, I find the variants that don't end the sentence before the conjunction
slightly nicer. But again, no strong opinion. So LGTM.

Powered by Google App Engine
This is Rietveld