Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(992)

Issue 29372653: Issue 4813 - UTFDataFormatException while serializing filter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by diegocarloslima
Modified:
2 years, 8 months ago
Reviewers:
Felix Dahlke, anton
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4813 - UTFDataFormatException while serializing filter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing Java 7 StandardCharsets for now #

Total comments: 2

Patch Set 3 : Including UTF-8 constant and adding migration/file corruption recovery logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -70 lines) Patch
M src/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java View 1 2 6 chunks +22 lines, -18 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java View 1 2 6 chunks +66 lines, -46 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java View 1 2 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11
diegocarloslima
2 years, 10 months ago (2017-01-18 13:37:05 UTC) #1
anton
https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java (right): https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode440 src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java:440: final byte[] b = s.getBytes(StandardCharsets.UTF_8); StandardCharsets is available starting ...
2 years, 9 months ago (2017-01-23 06:49:40 UTC) #2
diegocarloslima
On 2017/01/23 06:49:40, anton wrote: > https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java > File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java > (right): > > https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode440 ...
2 years, 9 months ago (2017-01-23 16:50:21 UTC) #3
anton
On 2017/01/23 16:50:21, diegocarloslima wrote: > On 2017/01/23 06:49:40, anton wrote: > > > https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java ...
2 years, 9 months ago (2017-01-24 05:48:56 UTC) #4
diegocarloslima
https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java (right): https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode440 src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java:440: final byte[] b = s.getBytes(StandardCharsets.UTF_8); On 2017/01/23 06:49:40, anton ...
2 years, 9 months ago (2017-01-30 17:14:30 UTC) #5
anton
On 2017/01/30 17:14:30, diegocarloslima wrote: > https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java > File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java > (right): > > https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode440 ...
2 years, 9 months ago (2017-02-15 11:01:54 UTC) #6
diegocarloslima
On 2017/02/15 11:01:54, anton wrote: > On 2017/01/30 17:14:30, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29372653/diff/29372654/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java ...
2 years, 9 months ago (2017-02-15 16:53:39 UTC) #7
anton
https://codereview.adblockplus.org/29372653/diff/29373692/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java (right): https://codereview.adblockplus.org/29372653/diff/29373692/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode439 src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java:439: final byte[] b = s.getBytes("UTF-8"); wouldn't it be better ...
2 years, 9 months ago (2017-02-16 06:17:24 UTC) #8
diegocarloslima
https://codereview.adblockplus.org/29372653/diff/29373692/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java (right): https://codereview.adblockplus.org/29372653/diff/29373692/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode439 src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java:439: final byte[] b = s.getBytes("UTF-8"); On 2017/02/16 06:17:24, anton ...
2 years, 8 months ago (2017-02-22 22:43:53 UTC) #9
anton
On 2017/02/22 22:43:53, diegocarloslima wrote: > https://codereview.adblockplus.org/29372653/diff/29373692/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java > File src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java > (right): > > https://codereview.adblockplus.org/29372653/diff/29373692/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java#newcode439 ...
2 years, 8 months ago (2017-03-13 08:04:07 UTC) #10
Felix Dahlke
2 years, 8 months ago (2017-03-13 09:21:56 UTC) #11
Didn't do a very thorough review, but LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5