Issue 4813 - UTFDataFormatException while serializing filter

src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 10 matching lines @@
 import java.io.BufferedOutputStream;
 import java.io.BufferedReader;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.StringReader;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ skipping 388 matching lines @@
       if (this.filters == null)
       {
         filtersOut.writeInt(0);
       }
       else
       {
         filtersOut.writeInt(this.filters.size());
         filtersOut.writeUTF(createFilterHash(new ArrayList<String>(this.filters)));
         for (final String s : this.filters)
         {
-          filtersOut.writeUTF(s);
+          final byte[] b = s.getBytes(StandardCharsets.UTF_8);

[anton, 2017/01/23 06:49:40]

StandardCharsets is available starting Java 7. If it's not a problem and
somewhere in README it's noted that JDK 7 is required then we can use it. For
JDK 6 we can use `Charset.forName("UTF-8")` instead

[diegocarloslima, 2017/01/30 17:14:30]

For instance, I'll use Charset.forName("UTF-8"). Then, I'll create a follow up
issue to add Java 7 features which I'll change this back to
StandardCharsets.UTF_8

+          filtersOut.writeInt(b.length);
+          filtersOut.write(b);
         }
       }
     }
     finally
     {
       filtersOut.close();
     }
   }
 
   public void serializeSubscription(final File metaFile, final File filtersFile) throws IOException
@@ skipping 36 matching lines @@
       if (numFilters == 0)
       {
         this.filters = null;
       }
       else
       {
         this.filters = new HashSet<String>();
         final String filtersHash = in.readUTF();
         for (int i = 0; i < numFilters; i++)
         {
-          this.filters.add(in.readUTF());
+          final int length = in.readInt();
+          final byte[] b = new byte[length];
+          in.readFully(b);
+          this.filters.add(new String(b, StandardCharsets.UTF_8));
         }
         this.filtersValid = createFilterHash(new ArrayList<String>(this.filters)).equals(
             filtersHash);
         Log.d(TAG, "Filters valid: " + this.filtersValid);
       }
     }
     finally
     {
       in.close();
     }
@@ skipping 123 matching lines @@
     this.serializeMetaData(metaFile);
     if (filtersChanged)
     {
       this.serializeFilters(filtersFile);
       this.clearFilters();
     }
 
     return filtersChanged;
   }
 }