Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/BaseJsTest.cpp

Issue 29372702: Issue #4826 - Use latch to replace thread-sleeping in tests
Patch Set: stray comments Created Jan. 20, 2017, 1:29 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/BaseJsTest.h ('k') | test/FileSystemJsObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/BaseJsTest.cpp
===================================================================
--- a/test/BaseJsTest.cpp
+++ b/test/BaseJsTest.cpp
@@ -29,11 +29,12 @@
jsEngine->SetLogSystem(std::make_shared<ThrowingLogSystem>());
jsEngine->SetFileSystem(std::make_shared<ThrowingFileSystem>());
jsEngine->SetWebRequest(std::make_shared<ThrowingWebRequest>());
+ engine = ToInternal(jsEngine);
}
void BaseJsTest::TearDown()
{
- ToInternal(jsEngine)->WaitForQuietScheduler();
+ engine->WaitForQuietScheduler();
EXPECT_EQ(1, jsEngine.use_count());
jsEngine.reset();
}
« no previous file with comments | « test/BaseJsTest.h ('k') | test/FileSystemJsObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld