Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(347)

Issue 29372800: [sitescripts] Issue 4827 - Added support for "relentless" notifications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by wspee
Modified:
2 years, 10 months ago
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

[sitescripts] Issue 4827 - Added support for "relentless" notifications

Patch Set 1 #

Patch Set 2 : Added tests #

Total comments: 2

Patch Set 3 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M sitescripts/notifications/parser.py View 2 chunks +3 lines, -1 line 0 comments Download
M sitescripts/notifications/test/parser.py View 1 2 7 chunks +47 lines, -26 lines 0 comments Download

Messages

Total messages: 6
wspee
2 years, 10 months ago (2017-01-20 14:02:08 UTC) #1
Vasily Kuznetsov
On 2017/01/20 14:02:08, wspee wrote: Hi Winsley, The changes to the parser look good. Do ...
2 years, 10 months ago (2017-01-23 13:49:13 UTC) #2
wspee
On 2017/01/23 13:49:13, Vasily Kuznetsov wrote: > On 2017/01/20 14:02:08, wspee wrote: > > Hi ...
2 years, 10 months ago (2017-01-25 10:38:11 UTC) #3
Vasily Kuznetsov
Hi Winsley! Looks even better with the tests. When I ran tox to check the ...
2 years, 10 months ago (2017-01-25 11:14:58 UTC) #4
wspee
Ah sorry was to eager to submit my changes ;) https://codereview.adblockplus.org/29372800/diff/29373631/sitescripts/notifications/test/parser.py File sitescripts/notifications/test/parser.py (right): https://codereview.adblockplus.org/29372800/diff/29373631/sitescripts/notifications/test/parser.py#newcode73 ...
2 years, 10 months ago (2017-01-25 11:50:00 UTC) #5
Vasily Kuznetsov
2 years, 10 months ago (2017-01-25 12:38:27 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5