Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29372820: Issue 4795 - Avoid shorthand method syntax where prototype matters (Closed)

Created:
Jan. 23, 2017, 1:42 p.m. by kzar
Modified:
Feb. 17, 2017, 1:55 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4795 - Avoid shorthand method syntax where prototype matters

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Sebastian's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M lib/compat.js View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
Jan. 23, 2017, 1:43 p.m. (2017-01-23 13:43:45 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js File lib/compat.js (right): https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js#newcode59 lib/compat.js:59: // We don't use the method definition shorthand syntax ...
Jan. 23, 2017, 1:54 p.m. (2017-01-23 13:54:22 UTC) #2
kzar
https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js File lib/compat.js (right): https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js#newcode59 lib/compat.js:59: // We don't use the method definition shorthand syntax ...
Jan. 23, 2017, 1:59 p.m. (2017-01-23 13:59:13 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js File lib/compat.js (right): https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js#newcode59 lib/compat.js:59: // We don't use the method definition shorthand syntax ...
Feb. 16, 2017, 12:05 p.m. (2017-02-16 12:05:10 UTC) #4
kzar
Patch Set 2 : Addressed Sebastian's feedback https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js File lib/compat.js (right): https://codereview.adblockplus.org/29372820/diff/29372821/lib/compat.js#newcode59 lib/compat.js:59: // We ...
Feb. 17, 2017, 9:40 a.m. (2017-02-17 09:40:28 UTC) #5
Sebastian Noack
Feb. 17, 2017, 12:08 p.m. (2017-02-17 12:08:21 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld