Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29372826: Issue 4836 - Have the setuptrans command use the current Crowdin API (Closed)

Created:
Jan. 24, 2017, 10:17 a.m. by kzar
Modified:
Jan. 25, 2017, 10:10 a.m.
Reviewers:
Wladimir Palant
CC:
kvas, Sebastian Noack
Visibility:
Public.

Description

Issue 4836 - Have the setuptrans command use the current Crowdin API

Patch Set 1 #

Total comments: 4

Patch Set 2 : Receive and parse locales as JSON #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M localeTools.py View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Jan. 24, 2017, 10:18 a.m. (2017-01-24 10:18:23 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29372826/diff/29372827/localeTools.py File localeTools.py (right): https://codereview.adblockplus.org/29372826/diff/29372827/localeTools.py#newcode322 localeTools.py:322: 'https://crowdin.com/languages/languages_list?callback=foo' Please use https://crowdin.com/languages/languages_list?callback=, the URL will give you ...
Jan. 24, 2017, 11:36 a.m. (2017-01-24 11:36:23 UTC) #2
kzar
Patch Set 2 : Receive and parse locales as JSON https://codereview.adblockplus.org/29372826/diff/29372827/localeTools.py File localeTools.py (right): https://codereview.adblockplus.org/29372826/diff/29372827/localeTools.py#newcode322 ...
Jan. 25, 2017, 3:45 a.m. (2017-01-25 03:45:04 UTC) #3
Wladimir Palant
Jan. 25, 2017, 8:10 a.m. (2017-01-25 08:10:32 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld