Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29373591: Issue 2734 - Configure new redirects from adblocklus.org (Closed)

Created:
Jan. 24, 2017, 3:27 p.m. by mathias
Modified:
Jan. 24, 2017, 6:02 p.m.
Reviewers:
f.nicolaisen
CC:
Fred, f.lopez
Visibility:
Public.

Description

Issue 2734 - Configure new redirects from adblocklus.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue 2734 - Address feedback from code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M modules/web/templates/adblockplus.org.conf.erb View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mathias
Jan. 24, 2017, 3:27 p.m. (2017-01-24 15:27:08 UTC) #1
f.nicolaisen
https://codereview.adblockplus.org/29373591/diff/29373592/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): https://codereview.adblockplus.org/29373591/diff/29373592/modules/web/templates/adblockplus.org.conf.erb#newcode185 modules/web/templates/adblockplus.org.conf.erb:185: rewrite ^ https://adblockplus.org/releases? redirect; It would be consistent with ...
Jan. 24, 2017, 3:35 p.m. (2017-01-24 15:35:14 UTC) #2
mathias
Jan. 24, 2017, 3:42 p.m. (2017-01-24 15:42:06 UTC) #3
f.nicolaisen
Jan. 24, 2017, 3:54 p.m. (2017-01-24 15:54:10 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld