Issue 4838 - Use nodeunit framework for integration tests running in browser

test/browser/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
 
   callback();
 };
 
 exports.tearDown = function(callback)
 {
   var styleElements = document.head.getElementsByTagName("style");
   while (styleElements.length)
     styleElements[0].parentNode.removeChild(styleElements[0]);
   callback();
-}
+};
 
 function expectHidden(test, element)
 {
   test.equal(window.getComputedStyle(element).display, "none",
              "The element's display property should be set to 'none'");
-};
+}
 
 function expectVisible(test, element)
 {
   test.notEqual(window.getComputedStyle(element).display, "none",
                 "The element's display property should not be set to 'none'");
-};
+}
 
 function findUniqueId()
 {
   var id = "elemHideEmulationTest-" + Math.floor(Math.random() * 10000);
   if (!document.getElementById(id))
     return id;
   return findUniqueId();
 }
 
 function insertStyleRule(rule)
 {
   var styleElement;
   var styleElements = document.head.getElementsByTagName("style");
   if (styleElements.length)
-  {
     styleElement = styleElements[0];
-  }
   else
   {
     styleElement = document.createElement("style");
     document.head.appendChild(styleElement);
   }
   styleElement.sheet.insertRule(rule, styleElement.sheet.cssRules.length);
 }
 
 function createElementWithStyle(styleBlock)
 {
   var element = document.createElement("div");
   element.id = findUniqueId();
   document.body.appendChild(element);
   insertStyleRule("#" + element.id + " " + styleBlock);
   return element;
 }
 
 function applyElemHideEmulation(selectors, callback)
 {
   if (typeof ElemHideEmulation == "undefined")
   {
     loadScript(myUrl + "/../../../lib/common.js", function()
     {
-      loadScript(myUrl + "/../../../chrome/content/elemHideEmulation.js", function()

[Felix Dahlke, 2017/01/30 14:37:59]

Can you wrap this to stay within 80 columns?

[Wladimir Palant, 2017/02/24 09:18:55]

Done. And while at it, I've done some linting in order to get other nits fixed
as well.

-      {
-        applyElemHideEmulation(selectors, callback);
-      });
+      loadScript(myUrl + "/../../../chrome/content/elemHideEmulation.js",
+          function()
+          {
+            applyElemHideEmulation(selectors, callback);
+          });
     });
     return;
   }
 
   var elemHideEmulation = new ElemHideEmulation(
     window,
     function(callback)
     {
       var patterns = [];
       selectors.forEach(function(selector)
@@ skipping 76 matching lines @@
   applyElemHideEmulation(
     ["[-abp-properties='/background.\\x7B0,6\\x7D: rgb\\(0, 0, 0\\)/']"],
     function()
     {
       expectVisible(test, toHide);
       test.done();
     }
   );
 };
 
-exports.testPropertySelectorWithDynamicallyChangedProperty = function(test)

[Felix Dahlke, 2017/01/30 14:37:59]

I found this easier to understand with "works for" rather than "with", but I can
see how it doesn't fit. Maybe just "testDynamicallyChangedProperty"? This tests
logic that is the same for all emulated features, I presume, therefore not
specific to property selectors.

[Wladimir Palant, 2017/02/24 09:18:55]

Done.

+exports.testDynamicallyChangedProperty = function(test)
 {
   var toHide = createElementWithStyle("{}");
   applyElemHideEmulation(
     ["[-abp-properties='background-color: rgb(0, 0, 0)']"],
     function()
     {
       expectVisible(test, toHide);
       insertStyleRule("#" + toHide.id + " {background-color: #000}");
       window.setTimeout(function()
       {
         expectHidden(test, toHide);
         test.done();
       }, 0);
     }
   );
 };