Issue 4838 - Use nodeunit framework for integration tests running in browser

package.json

Index: package.json
===================================================================
--- a/package.json
+++ b/package.json
@@ -1,15 +1,14 @@
 {
   "name": "adblockpluscore",
   "repository": "https://hg.adblockplus.org/adblockpluscore",
   "license": "GPL-3.0",
   "dependencies": {},
   "devDependencies": {
-    "node-qunit-phantomjs": "^1.5.0",
     "nodeunit": "0.9.1",
-    "qunitjs": "^2.1.0",
+    "phantomjs2": "^2.2.0",

[Felix Dahlke, 2017/01/30 14:37:58]

Why not use phantomjs-prebuilt [1], which is what node-qunit-phantomjs depended
on? The phantomjs2 package looks a bit dead - still refers to the old name of
the former package and claims it will only install PhantomJS 1.9.x.

[1]: https://www.npmjs.com/package/phantomjs-prebuilt

[Wladimir Palant, 2017/02/24 09:18:55]

This seems to be a misunderstanding - the package they forked was installing
PhantomJS 1.9.x, whereas phantomjs2 is installing PhantomJS 2.x. It will
currently install PhantomJS 2.1.1 which is the latest version.

My understanding was that phantomjs2 is the official distribution. I see now
that this is not the case. I don't see any real advantages of one over the
other, let's wait for PhantomJS 2.5 - if phantomjs-prebuilt gets updated sooner
we can easily switch to it again.

[Felix Dahlke, 2017/02/24 10:43:39]

How I see it, the story was like this:

1. The following package was called phantomjs:
https://github.com/Medium/phantomjs

2. The phantomjs2 guy forked it to support PhantomJS >=2, presumably because the
phantomjs package wasn't fast enough to update.

3. The phantomjs package renamed itself to phantomjs-prebuilt. From the NPM
page: "Pre-2.0, this package was published to NPM as phantomjs. We changed the
name to phantomjs-prebuilt at the request of PhantomJS team."

So phantomjs2 is a fork of phantomjs-prebuilt - and it seems to be slightly
behind. phantomjs-prebuilt had the last release in December 2016, phantomjs2 had
the last release in February 2016.

Ultimately I'm OK with phantomjs2. But phantomjs-prebuilt is the one I'd pick.

[Wladimir Palant, 2017/02/24 10:56:19]

Given that last PhantomJS release was in January 2016 - that's not "behind." ;)

As I said, I don't really have indicators as to which one is better to use.
We'll see when PhantomJS 2.5 comes out and switching is easy.

     "sandboxed-module": "2.0.3"
   },
   "scripts": {
     "test": "node test_runner.js"
   }
 }