Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29373674: Issue 3487 - Add links to the help tab (Closed)

Created:
Jan. 27, 2017, 5:20 p.m. by saroyanm
Modified:
March 3, 2017, 10:25 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3487 - Add links to the help tab

Patch Set 1 #

Total comments: 12

Patch Set 2 : Fixes according to Thomas comments #

Total comments: 1

Patch Set 3 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M new-options.html View 1 chunk +11 lines, -5 lines 0 comments Download
M new-options.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M skin/new-options.css View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7
saroyanm
https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js File new-options.js (right): https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js#newcode855 new-options.js:855: ext.backgroundPage.sendMessage( I think we create a function, similar to ...
Jan. 27, 2017, 5:23 p.m. (2017-01-27 17:23:43 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29373674/diff/29373675/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29373674/diff/29373675/messageResponder.js#newcode190 messageResponder.js:190: return info.platform; See line 192. https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js File new-options.js (right): ...
Jan. 31, 2017, 2:29 p.m. (2017-01-31 14:29:23 UTC) #2
saroyanm
https://codereview.adblockplus.org/29373674/diff/29373675/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29373674/diff/29373675/messageResponder.js#newcode190 messageResponder.js:190: return info.platform; On 2017/01/31 14:29:22, Thomas Greiner wrote: > ...
Feb. 1, 2017, 1:22 p.m. (2017-02-01 13:22:18 UTC) #3
Thomas Greiner
https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js File new-options.js (right): https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js#newcode852 new-options.js:852: }); On 2017/02/01 13:22:18, saroyanm wrote: > On 2017/01/31 ...
Feb. 2, 2017, 12:28 p.m. (2017-02-02 12:28:47 UTC) #4
saroyanm
New patch uploaded. https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js File new-options.js (right): https://codereview.adblockplus.org/29373674/diff/29373675/new-options.js#newcode855 new-options.js:855: ext.backgroundPage.sendMessage( On 2017/02/02 12:28:47, Thomas Greiner ...
Feb. 8, 2017, 1:13 p.m. (2017-02-08 13:13:29 UTC) #5
Thomas Greiner
LGTM, just added a small comment. In regards to the discussion about the messaging API ...
March 2, 2017, 3:17 p.m. (2017-03-02 15:17:47 UTC) #6
Thomas Greiner
March 2, 2017, 7:13 p.m. (2017-03-02 19:13:26 UTC) #7
FYI: There is a ticket already in which we're discussing changes to the
messaging API (see https://issues.adblockplus.org/ticket/4492).

Powered by Google App Engine
This is Rietveld