Issue 3487 - Add links to the help tab

new-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 807 matching lines @@
         filterTextbox.value = "";
       });
     }
     E("custom-filters-add").addEventListener("submit", function(e)
     {
       e.preventDefault();
       addCustomFilters();
     }, false);
     var customFilterEditButtons = document.querySelectorAll("#custom-filters-edit-wrapper button");
 
-    //Help tab
+    // Help tab
     getDocLink("faq", function(link)
     {
       E("link-faq").setAttribute("href", link);
     });
     getDocLink("social_twitter", function(link)
     {
       E("link-twitter").setAttribute("href", link);
     });
     getDocLink("social_facebook", function(link)
     {
       E("link-facebook").setAttribute("href", link);
     });
     getDocLink("social_gplus", function(link)
     {
       E("link-gplus").setAttribute("href", link);
     });
     getDocLink("social_renren", function(link)
     {
       E("link-renren").setAttribute("href", link);
     });
     getDocLink("social_weibo", function(link)
     {
       E("link-weibo").setAttribute("href", link);
     });

[Thomas Greiner, 2017/01/31 14:29:22]

We should definitely try to make this more elegant and more efficient (same
applies for setting doclinks in the first-run page) but feel free to tackle that
in a separate ticket.

[saroyanm, 2017/02/01 13:22:18]

Agree, we can discuss details in #4856

[Thomas Greiner, 2017/02/02 12:28:47]

Thanks.

 
     // Set forum link
     ext.backgroundPage.sendMessage(

[saroyanm, 2017/01/27 17:23:43]

I think we create a function, similar to the "getDocLink" for "app.get"
requests.

[Thomas Greiner, 2017/01/31 14:29:22]

I guess you're referring to
https://hg.adblockplus.org/adblockpluschrome/file/tip/options.js#l63 but I don't
think that's necessary unless we use a specific type of message more often.

Instead, we could've just implemented an abstraction layer if we wanted to hide
away all `ext.backgroundPage.sendMessage()` calls but for some reason we didn't.
So if it turns out that those calls are way too numerous and tedious, I'd rather
introduce one than making custom (inconsistent) functions for each individual
message.

[saroyanm, 2017/02/01 13:22:18]

Agree, you want me to tackle it here, or in a separate issue ?

[Thomas Greiner, 2017/02/02 12:28:47]

Let's tackle this separately. It does look like nobody is happy with the way the
messaging API should be used so finding a better solution is way out of scope
for this review.

[saroyanm, 2017/02/08 13:13:29]

I'm having a hard time of thinking about the new ticket description, can you
please create a ticket if you have one generic idea in mind, or we can discuss
together how we can improve the usage of "messaging API", I feel like I don't
have all details considering `It does look like nobody is happy with the way the
messaging API should be used` point.

     {
       type: "app.get",
       what: "platform"
     },
     function(platform)
     {
       ext.backgroundPage.sendMessage(
       {
         type: "app.get",
         what: "application"
@@ skipping 450 matching lines @@
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
         "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 })();