Issue 4864 - Start using ESLint for adblockpluschrome

notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 81 matching lines @@
   notificationElement.hidden = false;
   notificationElement.addEventListener("click", event =>
   {
     switch (event.target.id)
     {
       case "notification-close":
         notificationElement.classList.add("closing");
         break;
       case "notification-optout":
         Notification.toggleIgnoreCategory("*", true);
+        // Falls through.

[Sebastian Noack, 2017/02/09 01:04:51]

Interesting, this isn't a regular eslint comment, and without one it should
complain here. Either way, how about turning the switch/case into an if instead?

[kzar, 2017/02/20 10:27:33]

Yea, I thought this was kind of interesting too. I do understand the logic
though, I think case clauses which fall through can be a little confusing but
are fine so long as that they're documented.
I'm not sure why we should change it? IMO using a switch here is OK.

       case "notification-hide":
         notificationElement.hidden = true;
         notification.onClicked();
         break;
     }
   }, true);
 }, false);