.eslintrc.json - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .eslintrc.json

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Fixed typo with shadowRoot getter Created March 14, 2017, 10:28 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "extends": "eslint-config-eyeo",

	3 "root": true,

	4 "env": {

	5 "browser": true,

	6 "webextensions": true
	Wladimir Palant 2017/03/14 13:03:22 Isn't "browser" already implied by "webextensions" Isn't "browser" already implied by "webextensions"? Did you test that? kzar 2017/03/15 04:57:44 Apparently not, when I remove "browser" I get a bu Show quoted text On 2017/03/14 13:03:22, Wladimir Palant wrote: > Isn't "browser" already implied by "webextensions"? Did you test that? Apparently not, when I remove "browser" I get a bunch of no-undef errors for things like `window`, `document` and `console`.
	7 },

	8 "globals": {

	9 "exports": true,

	10 "ext": true,

	11 "require": true

	12 }

	13 }

OLD	NEW

« no previous file with comments | « .eslintignore ('k') | README.md » ('j') | chrome/ext/popup.js » ('J')