chrome/ext/popup.js - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/ext/popup.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Fixed typo with shadowRoot getter Created March 14, 2017, 10:28 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 "use strict";	1 "use strict";

2	2

	3 (function()

3 {	4 {

4 const backgroundPage = chrome.extension.getBackgroundPage();	5 const backgroundPage = chrome.extension.getBackgroundPage();

5 var ext = Object.create(backgroundPage.ext);	6 ext = Object.create(backgroundPage.ext);
	Wladimir Palant 2017/03/14 13:03:22 As far as the browser is concerned, ext is an unde As far as the browser is concerned, ext is an undeclared variable here. So IMHO this should throw because of "use strict". Assign to window.ext instead? kzar 2017/03/15 04:57:44 Done. Show quoted text On 2017/03/14 13:03:22, Wladimir Palant wrote: > As far as the browser is concerned, ext is an undeclared variable here. So IMHO > this should throw because of "use strict". Assign to window.ext instead? Done.
6	7

7 ext.closePopup = () =>	8 ext.closePopup = () =>

8 {	9 {

9 window.close();	10 window.close();

10 };	11 };

11	12

12 // We have to override ext.backgroundPage, because in order	13 // We have to override ext.backgroundPage, because in order

13 // to send messages the local "chrome" namespace must be used.	14 // to send messages the local "chrome" namespace must be used.

14 ext.backgroundPage = {	15 ext.backgroundPage = {

15 sendMessage: chrome.runtime.sendMessage,	16 sendMessage: chrome.runtime.sendMessage,

16	17

17 getWindow()	18 getWindow()

18 {	19 {

19 return backgroundPage;	20 return backgroundPage;

20 }	21 }

21 };	22 };

22 }	23 }());

OLD	NEW