Issue 4864 - Start using ESLint for adblockpluschrome

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 115 matching lines @@
       ext.showOptions(page =>
       {
         page.sendMessage({
           type: "app.respond",
           action: "focusSection",
           args: ["notifications"]
         });
       });
       break;
     case "question":
-      NotificationStorage.triggerQuestionListeners(activeNotification.id, buttonIndex == 0);
+      NotificationStorage.triggerQuestionListeners(activeNotification.id,
+                                                   buttonIndex == 0);
       NotificationStorage.markAsShown(activeNotification.id);
       activeNotification.onClicked();
       break;
   }
 }
 
 function notificationClosed()
 {
   activeNotification = null;
 }
 
 function initChromeNotifications()
 {
-  // Chrome hides notifications in notification center when clicked so we need to clear them
+  // Chrome hides notifications in notification center when clicked so
+  // we need to clear them.
   function clearActiveNotification(notificationId)
   {
-    if (activeNotification && activeNotification.type != "question" && !("links" in activeNotification))
+    if (activeNotification &&
+        activeNotification.type != "question" &&
+        !("links" in activeNotification))
       return;
 
     chrome.notifications.clear(notificationId, wasCleared =>
     {
       if (wasCleared)
         notificationClosed();
     });
   }
 
-  chrome.notifications.onButtonClicked.addListener((notificationId, buttonIndex) =>
-  {
-    notificationButtonClick(buttonIndex);
-    clearActiveNotification(notificationId);
-  });
+  chrome.notifications.onButtonClicked.addListener(
+    (notificationId, buttonIndex) =>
+    {
+      notificationButtonClick(buttonIndex);
+      clearActiveNotification(notificationId);
+    }
+  );
   chrome.notifications.onClicked.addListener(clearActiveNotification);
   chrome.notifications.onClosed.addListener(notificationClosed);
 }
 
 function showNotification(notification)
 {
   if (activeNotification && activeNotification.id == notification.id)
     return;
 
   activeNotification = notification;
   if (shouldDisplay("notification", activeNotification.type))
   {
     let texts = NotificationStorage.getLocalizedTexts(notification);
     let title = texts.title || "";
-    let message = texts.message ? texts.message.replace(/<\/?(a|strong)>/g, "") : "";
+    let message = (texts.message || "").replace(/<\/?(a|strong)>/g, "");
     let iconUrl = ext.getURL("icons/detailed/abp-128.png");
     let linkCount = (activeNotification.links || []).length;
 
     if ("notifications" in chrome)
     {
-      activeButtons = getNotificationButtons(activeNotification.type, texts.message);
+      activeButtons = getNotificationButtons(activeNotification.type,
+                                             texts.message);
       chrome.notifications.create("", {
         type: "basic",
-        title: title,
-        iconUrl: iconUrl,
-        message: message,
+        title,
+        iconUrl,
+        message,
         buttons: activeButtons.map(button => ({title: button.title})),
-        priority: 2 // We use the highest priority to prevent the notification from closing automatically
+        // We use the highest priority to prevent the notification
+        // from closing automatically.
+        priority: 2
       });
     }
     else if ("Notification" in window && activeNotification.type != "question")
     {
       if (linkCount > 0)
         message += " " + ext.i18n.getMessage("notification_without_buttons");
 
-      let notification = new Notification(
+      let widget = new Notification(
         title,
         {
           lang: Utils.appLocale,
           dir: ext.i18n.getMessage("@@bidi_dir"),
           body: message,
           icon: iconUrl
         }
       );
 
-      notification.addEventListener("click", openNotificationLinks);
-      notification.addEventListener("close", notificationClosed);
+      widget.addEventListener("click", openNotificationLinks);
+      widget.addEventListener("close", notificationClosed);
     }
     else
     {
-      let message = title + "\n" + message;
+      message = title + "\n" + message;
       if (linkCount > 0)
         message += "\n\n" + ext.i18n.getMessage("notification_with_buttons");
 
       let approved = confirm(message);
       if (activeNotification.type == "question")
         notificationButtonClick(approved ? 0 : 1);
       else if (approved)
         openNotificationLinks();
     }
   }
   prepareNotificationIconAndPopup();
 
   if (notification.type !== "question")
     NotificationStorage.markAsShown(notification.id);
-};
+}
 
 /**
  * Initializes the notification system.
  */
 exports.initNotifications = () =>
 {
   if ("notifications" in chrome)
     initChromeNotifications();
   initAntiAdblockNotification();
 };
@@ skipping 19 matching lines @@
   let methods = displayMethods[notificationType] || defaultDisplayMethods;
   return methods.indexOf(method) > -1;
 };
 
 ext.pages.onLoading.addListener(page =>
 {
   NotificationStorage.showNext(stringifyURL(page.url));
 });
 
 NotificationStorage.addShowListener(showNotification);