dependencies - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: dependencies

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Rebased, restored adblockplusui dependency revision Created March 22, 2017, 7:10 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97	3 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97

4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447	4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447

5 adblockpluscore = adblockpluscore hg:c7ae7532578a git:50ebfcf	5 adblockpluscore = adblockpluscore hg:68a4dc4e79e8 git:2574147

6 adblockplusui = adblockplusui hg:673e908d3bb4 git:1db1e7d	6 adblockplusui = adblockplusui hg:a78bfd4024b7 git:0feaaf7
	Sebastian Noack 2017/03/23 06:38:37 It seems you did a mistake while rebasing. The las It seems you did a mistake while rebasing. The last commit in the adblockplusui repository is 8ceaabb9c639, which is already referenced here. kzar 2017/03/23 06:51:01 Not a mistake, I rebased before Jon's commit lande Show quoted text On 2017/03/23 06:38:37, Sebastian Noack wrote: > It seems you did a mistake while rebasing. The last commit in the adblockplusui > repository is 8ceaabb9c639, which is already referenced here. Not a mistake, I rebased before Jon's commit landed to update the adblockplusui dependency. Rebased again to include that now. (Also not a mistake that I did not update the dependency to be the latest revision, I did that on purpose. Since Wladimir pointed out with the anti-adblock notification problem we should be careful when updating dependencies for unrelated issues, like I did in #4136.)
OLD	NEW

« no previous file with comments | « composer.postload.js ('k') | ext/background.js » ('j') | no next file with comments »