README.md - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Remove extra space Created March 23, 2017, 10:30 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Adblock Plus for Chrome and Opera	1 Adblock Plus for Chrome and Opera

2 =================================	2 =================================

3	3

4 This repository contains the platform-specific Adblock Plus source code for	4 This repository contains the platform-specific Adblock Plus source code for

5 Chrome and Opera. It can be used to build Adblock Plus for these platforms,	5 Chrome and Opera. It can be used to build Adblock Plus for these platforms,

6 generic Adblock Plus code will be extracted from other repositories	6 generic Adblock Plus code will be extracted from other repositories

7 automatically (see _dependencies_ file).	7 automatically (see _dependencies_ file).

8	8

9 Building	9 Building

10 ---------	10 ---------

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 Running the unit tests	43 Running the unit tests

44 ----------------------	44 ----------------------

45	45

46 To verify your changes you can use the unit test suite located in the _qunit_	46 To verify your changes you can use the unit test suite located in the _qunit_

47 directory of the repository. In order to run the unit tests go to the	47 directory of the repository. In order to run the unit tests go to the

48 extension's Options page, open the JavaScript Console and type in:	48 extension's Options page, open the JavaScript Console and type in:

49	49

50 location.href = "qunit/index.html";	50 location.href = "qunit/index.html";

51	51

52 The unit tests will run automatically once the page loads.	52 The unit tests will run automatically once the page loads.

	53

	54 Linting

	55 -------

	56

	57 You can lint the code using [ESLint](http://eslint.org).

	58

	59 eslint *.js lib/ qunit/ ext/ chrome/
	Sebastian Noack 2017/03/29 17:14:09 Do you have to specify all files/subdirectories? C Do you have to specify all files/subdirectories? Can't you just run `eslint .`?
	60

	61 You will need to set up ESLint and our configuration first, see

	62 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

	63 for more information.

OLD	NEW

« no previous file with comments | « .eslintrc.json ('k') | background.js » ('j') | chrome/ext/common.js » ('J')