dependencies - Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: dependencies

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)

Patch Set: Remove extra space Created March 23, 2017, 10:30 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97	3 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97

4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447	4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447

5 adblockpluscore = adblockpluscore hg:c7ae7532578a git:50ebfcf	5 adblockpluscore = adblockpluscore hg:68a4dc4e79e8 git:2574147
	Sebastian Noack 2017/03/29 17:14:14 Why exactly do we have to update the adblockplusco Why exactly do we have to update the adblockpluscore dependency for these changes again? If it is just so we use a version of adblockpluscore that follows the same coding style, this would arguably be unrelated. But if this dependency update is actually necessary, so that everything works with these changes, the issue description should probably mention it (along the changes pulled in). While speaking about the issue description, it seems a bit outdated. kzar 2017/03/30 07:20:45 Well I guess since I was testing the changes all t Show quoted text On 2017/03/29 17:14:14, Sebastian Noack wrote: > Why exactly do we have to update the adblockpluscore dependency > for these changes again? Well I guess since I was testing the changes all together to make sure they really worked. Also some changes to the Cu.import stub were required for the adblockpluscore dependency update. But I guess you're right that strictly the dependency update could be done separately. I've opened https://issues.adblockplus.org/ticket/5061 for that.
6 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2	6 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2

OLD	NEW

« composer.postload.js ('K') | « composer.postload.js ('k') | ext/background.js » ('j') | lib/csp.js » ('J')