Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .eslintrc.json
Issue
29374674
:
Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Patch Set: Address Sebastian's feedback, don't update adblockpluscore
Created March 30, 2017, 7:08 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Reduce inline eslint-disable comments
Patch Set 3: Use var for ext declarations again
Patch Set 4: Addressed some of Sebastian's feedback, made other improvements
Patch Set 5: Stop using commonjs
Patch Set 6: Rebased.
Patch Set 7: Rebased.
Patch Set 8: Add arrow-parens rule to match existing convention
Patch Set 9: Update Cu.import use to correspond with adblockpluscore changes, removed unused utils.js file
Patch Set 10: Remove the arrow-parens rule
Patch Set 11: Restored IIFEs and chrome/ext/common.js
Patch Set 12: Fixed typo with shadowRoot getter
Patch Set 13: Addressed Wladimir's feedback
Patch Set 14: Update adblockpluscore dependency
Patch Set 15: Update adblockplusui dependency
Patch Set 16: Rebased
Patch Set 17: Update adblockplusui dependency to include the notification fix
Patch Set 18: Rebased, restored adblockplusui dependency revision
Patch Set 19: Rebased
Patch Set 20: Remove some unnecessary changes
Patch Set 21: Remove extra space
Patch Set 22: Rebased to include Jon's webRequest WebSocket blocking changes
Patch Set 23: Address Sebastian's feedback, don't update adblockpluscore
Patch Set 24: Tidy up hasRecord and some notification logic
Patch Set 25: Remove two globals from tests
Patch Set 26: Addressed more feedback
Patch Set 27: Use .includes again
Right:
Patch Set 1: None
Patch Set 2: Reduce inline eslint-disable comments
Patch Set 3: Use var for ext declarations again
Patch Set 4: Addressed some of Sebastian's feedback, made other improvements
Patch Set 5: Stop using commonjs
Patch Set 6: Rebased.
Patch Set 7: Rebased.
Patch Set 8: Add arrow-parens rule to match existing convention
Patch Set 9: Update Cu.import use to correspond with adblockpluscore changes, removed unused utils.js file
Patch Set 10: Remove the arrow-parens rule
Patch Set 11: Restored IIFEs and chrome/ext/common.js
Patch Set 12: Fixed typo with shadowRoot getter
Patch Set 13: Addressed Wladimir's feedback
Patch Set 14: Update adblockpluscore dependency
Patch Set 15: Update adblockplusui dependency
Patch Set 16: Rebased
Patch Set 17: Update adblockplusui dependency to include the notification fix
Patch Set 18: Rebased, restored adblockplusui dependency revision
Patch Set 19: Rebased
Patch Set 20: Remove some unnecessary changes
Patch Set 21: Remove extra space
Patch Set 22: Rebased to include Jon's webRequest WebSocket blocking changes
Patch Set 23: Address Sebastian's feedback, don't update adblockpluscore
Patch Set 24: Tidy up hasRecord and some notification logic
Patch Set 25: Remove two globals from tests
Patch Set 26: Addressed more feedback
Patch Set 27: Use .includes again
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.eslintignore
.eslintrc.json
README.md
background.js
chrome/devtools.js
chrome/ext/background.js
chrome/ext/common.js
chrome/ext/content.js
chrome/ext/devtools.js
chrome/ext/popup.js
composer.js
composer.postload.js
ext/background.js
ext/common.js
include.preload.js
lib/compat.js
lib/csp.js
lib/devtools.js
lib/filterComposer.js
lib/filterValidation.js
lib/icon.js
lib/io.js
lib/messaging.js
lib/notificationHelper.js
lib/popupBlocker.js
lib/prefs.js
lib/requestBlocker.js
lib/subscriptionInit.js
lib/tldjs.js
lib/url.js
lib/utils.js
lib/whitelisting.js
notification.js
options.js
popup.js
qunit/.eslintrc.json
qunit/common.js
qunit/tests/cssEscaping.js
qunit/tests/filterValidation.js
qunit/tests/prefs.js
qunit/tests/url.js
qunit/tests/versionComparator.js
stats.js
subscriptionLink.postload.js
utils.js
View unified diff
|
Download patch
« no previous file with comments
|
« .eslintignore
('k') |
README.md »
('j') |
lib/devtools.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"extends": "eslint-config-eyeo",
3
"root": true,
4
"env": {
5
"browser": true,
6
"webextensions": true
7
},
8
"globals": {
9
"exports": true,
10
"ext": true,
11
"require": true
12
}
13
}
OLD
NEW
« no previous file with comments
|
« .eslintignore
('k') |
README.md »
('j') |
lib/devtools.js »
('J')
Edit Message
Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Created Feb. 7, 2017, 4:49 p.m. by kzar
Modified March 31, 2017, 8:48 a.m.
Reviewers: Sebastian Noack
Base URL:
Comments: 92
+ 2 drafts
This is Rietveld