Issue 4864 - Start using ESLint for adblockpluschrome

notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 72 matching lines @@
     event.preventDefault();
     event.stopPropagation();
     ext.pages.open(link.href);
   });
 
   let notificationElement = document.getElementById("notification");
   notificationElement.className = notification.type;
   notificationElement.hidden = false;
   notificationElement.addEventListener("click", event =>
   {
-    switch (event.target.id)
+    if (event.target.id == "notification-close")
+      notificationElement.classList.add("closing");
+    else if (event.target.id == "notification-optout")
     {
-      case "notification-close":
-        notificationElement.classList.add("closing");
-        break;
-      case "notification-optout":
-        Notification.toggleIgnoreCategory("*", true);
-      case "notification-hide":
-        notificationElement.hidden = true;
-        notification.onClicked();
-        break;
+      Notification.toggleIgnoreCategory("*", true);
+      notificationElement.hidden = true;

[Sebastian Noack, 2017/03/31 07:59:39]

If you just duplicate these lines, you could have sticked with switch/case, no
fall through needed then.

The point of using if/else here is that you can implement the same logic with
less duplication but no fall through:

  if (event.target.id == "notification-close")
    notificationElement.classList.add("closing");
  else if (event.target.id == "notification-optout" ||
           event.target.id == "notification-hide")
  {
    if (event.target.id == "notification-optout")
      Notification.toggleIgnoreCategory("*", true);

    notificationElement.hidden = true;
    notification.onClicked();
  }

+      notification.onClicked();
+    }
+    else if (event.target.id == "notification-hide")
+    {
+      notificationElement.hidden = true;
+      notification.onClicked();
     }
   }, true);
 }, false);