Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/icon.js

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Left Patch Set: Created Feb. 7, 2017, 4:49 p.m.
Right Patch Set: Use .includes again Created March 31, 2017, 8:37 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/filterValidation.js ('k') | lib/io.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 { 196 {
197 stopRequested = false; 197 stopRequested = false;
198 }); 198 });
199 }; 199 };
200 200
201 /** 201 /**
202 * Starts to animate the browser action icon to indicate a pending notifcation. 202 * Starts to animate the browser action icon to indicate a pending notifcation.
203 * If the icon is already animated, it replaces the previous 203 * If the icon is already animated, it replaces the previous
204 * animation as soon as the current interval has been finished. 204 * animation as soon as the current interval has been finished.
205 * 205 *
206 * @param {string} type The notification type (i.e: "information" or 206 * @param {string} type The notification type (i.e: "information" or
207 * "critical".) 207 * "critical".)
208 */ 208 */
209 exports.startIconAnimation = type => 209 exports.startIconAnimation = type =>
210 { 210 {
211 notRunning = new Promise(resolve => 211 notRunning = new Promise(resolve =>
212 { 212 {
213 Promise.all([renderFrames(type), stopIconAnimation()]).then(results => 213 Promise.all([renderFrames(type), stopIconAnimation()]).then(results =>
214 { 214 {
215 if (stopRequested) 215 if (stopRequested)
216 { 216 {
217 resolve(); 217 resolve();
(...skipping 10 matching lines...) Expand all
228 clearInterval(interval); 228 clearInterval(interval);
229 resolve(); 229 resolve();
230 return; 230 return;
231 } 231 }
232 232
233 animateIcon(type, frames); 233 animateIcon(type, frames);
234 }, 10000); 234 }, 10000);
235 }); 235 });
236 }); 236 });
237 }; 237 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld