Issue 4864 - Start using ESLint for adblockpluschrome

chrome/ext/popup.js

 "use strict";
 
+(function()
 {
   const backgroundPage = chrome.extension.getBackgroundPage();
+  window.ext = Object.create(backgroundPage.ext);
 
-  /* eslint-disable no-var */
-  var ext = Object.create(backgroundPage.ext);

[Sebastian Noack, 2017/02/09 01:04:49]

The popup code (also) broke because you used Object.create(backgroundPage)
instead of Object.create(backgroundPage.ext). I cannot see any other obvious
problem. If there is, please figure out and explain what is happening there. It
really should be possible to avoid var here.

[kzar, 2017/02/20 10:27:30]

Ah well spotted, Done.

-  /* eslint-enable no-var */
-
-  ext.closePopup = () =>
+  window.ext.closePopup = () =>
   {
     window.close();
   };
 
   // We have to override ext.backgroundPage, because in order
   // to send messages the local "chrome" namespace must be used.
-  ext.backgroundPage = {
+  window.ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
 
     getWindow()
     {
       return backgroundPage;
     }
   };
-}
+}());