Issue 4864 - Start using ESLint for adblockpluschrome

lib/icon.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 182 matching lines @@
   {
     stopRequested = false;
   });
 };
 
 /**
  * Starts to animate the browser action icon to indicate a pending notifcation.
  * If the icon is already animated, it replaces the previous
  * animation as soon as the current interval has been finished.
  *
- * @param {string} type The notification type (i.e: "information" or

[Sebastian Noack, 2017/02/09 01:04:51]

The redundant space between the type and description made it easier to parse
(for humans) if the description isn't capitalized. I wouldn't insist on keeping
up that practice, but please make sure that all argument descriptions across our
code will be capitalized then, to don't regress the readability.

[kzar, 2017/02/20 10:27:32]

Done.

- *                      "critical".)
+ * @param {string} type  The notification type (i.e: "information" or
+ *                       "critical".)
  */
 exports.startIconAnimation = type =>
 {
   notRunning = new Promise(resolve =>
   {
     Promise.all([renderFrames(type), stopIconAnimation()]).then(results =>
     {
       if (stopRequested)
       {
         resolve();
@@ skipping 10 matching lines @@
           clearInterval(interval);
           resolve();
           return;
         }
 
         animateIcon(type, frames);
       }, 10000);
     });
   });
 };