Issue 4864 - Start using ESLint for adblockpluschrome

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* global $, i18n, i18n_timeDateStrings */
+/* global $, i18n, i18nTimeDateStrings */
 
 "use strict";
 
 /**
  * Creates a wrapping function used to conveniently send a type of message.
  *
  * @param {Object} baseMessage The part of the message that's always sent
  * @param {...string} paramKeys Any message keys that have dynamic values. The
  *                              returned function will take the corresponding
  *                              values as arguments.
  * @return {function} The generated messaging function, optionally
  *                    taking any values as specified by the paramKeys
  *                    and finally an optional callback.  (Although the
  *                    value arguments are optional their index must be
  *                    maintained. E.g. if you omit the first value you
  *                    must omit the second too.)
  */
 function wrapper(baseMessage, ...paramKeys)

[Sebastian Noack, 2017/02/09 01:04:51]

How about calling the rest arguments just "args" as you did elsewhere?

[kzar, 2017/02/20 10:27:33]

Since paramKeys is a more useful name. (I used `args` elsewhere when I couldn't
think of a better name, but I wasn't too happy about doing so.)

The function that wrapper returns accepts parameters based upon the names given
by paramKeys. The paramKeys and passed in paramValues are then combined into the
message Object which is sent. I think renaming paramKeys to args would make that
less clear.

 {
   return function(...paramValues /* , callback */)
   {
     let message = Object.create(null);
     for (let key in baseMessage)
     {
       if (baseMessage.hasOwnProperty(key))
         message[key] = baseMessage[key];
     }
 
@@ skipping 298 matching lines @@
   }
   updateSubscriptionSelection();
   document.getElementById("addSubscriptionContainer").scrollIntoView(true);
 }
 
 function updateSubscriptionSelection()
 {
   let list = document.getElementById("subscriptionSelector");
   let data = list.options[list.selectedIndex]._data;
   if (data)
-  {
     $("#customSubscriptionContainer").hide();
-  }
   else
   {
     $("#customSubscriptionContainer").show();
     $("#customSubscriptionTitle").focus();
   }
 }
 
 function addSubscriptionClicked()
 {
   let list = document.getElementById("subscriptionSelector");
   let data = list.options[list.selectedIndex]._data;
   if (data)
-  {
     addSubscription(data.url, data.title, data.homepage);
-  }
   else
   {
     let url = document.getElementById("customSubscriptionLocation")
-      .value.trim();
+                      .value.trim();
     if (!/^https?:/i.test(url))
     {
       alert(i18n.getMessage("global_subscription_invalid_location"));
       $("#customSubscriptionLocation").focus();
       return;
     }
 
     let title = document.getElementById("customSubscriptionTitle").value.trim();
     if (!title)
       title = url;
@@ skipping 51 matching lines @@
   }
   else if (downloadStatus && downloadStatus != "synchronize_ok")
   {
     if (statusMessages.has(downloadStatus))
     {
       lastUpdate.textContent = i18n.getMessage(
         statusMessages.get(downloadStatus)
       );
     }
     else
-    {
       lastUpdate.textContent = downloadStatus;
-    }
     lastUpdate.classList.add("error");
   }
   else if (subscription.lastDownload > 0)
   {
-    let timeDate = i18n_timeDateStrings(subscription.lastDownload * 1000);
+    let timeDate = i18nTimeDateStrings(subscription.lastDownload * 1000);
     let messageID = (timeDate[1] ? "last_updated_at" : "last_updated_at_today");
     lastUpdate.textContent = i18n.getMessage(messageID, timeDate);
   }
 }
 
 function onSubscriptionMessage(action, subscription)
 {
   let element = findSubscriptionElement(subscription);
 
   switch (action)
@@ skipping 279 matching lines @@
       onFilterMessage(message.action, message.args[0]);
       break;
     case "prefs.respond":
       onPrefMessage(message.action, message.args[0]);
       break;
     case "subscriptions.respond":
       onSubscriptionMessage(message.action, message.args[0]);
       break;
   }
 });